Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popup): applying focus twice #10556

Merged
merged 3 commits into from
Jan 20, 2025
Merged

fix(popup): applying focus twice #10556

merged 3 commits into from
Jan 20, 2025

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Jan 14, 2025 •
edited
Loading

Applying focus twice might result into an issue if navigation occurs before promise for second focus is resolved.

TeodorTaushanov
TeodorTaushanov requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@TeodorTaushanov TeodorTaushanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the await renderFinished();, because we want the open event to be triggered only after rendering is complete.

@nnaydenow nnaydenow merged commit 27721a9 into main Jan 20, 2025
10 checks passed
@nnaydenow nnaydenow deleted the popup-focus branch January 20, 2025 15:44
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.7.0-rc.1 🎉

The release is available on v2.7.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnaydenow @ui5-webcomponents-bot @TeodorTaushanov