fix(ui5-avatar-group): click event is fired only once #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avatar-keyDown-group-event
…o avatar-keyDown-group-event
…i5-webcomponents into avatar-keyDown-group-event
…i5-webcomponents into avatar-keyDown-group-event
…i5-webcomponents into avatar-keyDown-group-event
|
|
dobrinyonkov
changed the title
PetyaMarkovaBogdanova
approved these changes
Apr 29, 2021
fifoosid
approved these changes
May 5, 2021
ilhan007
pushed a commit
that referenced
this pull request
May 10, 2021
ilhan007
pushed a commit
that referenced
this pull request
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3133
Summary:
typeis eqaul toGroupand forIndividual, the logic is handled in the_onClickand_onUI5Clickmethodsui5-avatarfiresui5-clickevent on Space and Enter so no handling is requred in the keyup/keydown handlers of the groupui5-buttonfiresclickevent on Space and Enter - also, no handling requred from ui5-avatar-group