fix(ui5-SegmentedButton): keyboard handling now compliant with the specification #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
Aug 23, 2021
packages/main/src/SegmentedButton.js
Outdated
| } | ||
| } | ||
|
|
||
| _onPageUpOrDown(pageUpPressed) { |
There was a problem hiding this comment.
This function doesn't make the code more readable or structured. Better execute the code on place.
ilhan007
reviewed
Aug 23, 2021
packages/main/src/SegmentedButton.js
Outdated
| @@ -213,7 +218,25 @@ class SegmentedButton extends UI5Element { | |||
| this._selectItem(event); | |||
| } else if (isSpace(event)) { | |||
| event.preventDefault(); | |||
| } else if (isPageUp(event)) { | |||
| event.preventDefault(); | |||
| this._onPageUpOrDown(isPageUp(event)); | |||
There was a problem hiding this comment.
if you are already in this "if" block I think isPageUp(event) in "this._onPageUpOrDown(isPageUp(event))" is always true as already checked "else if (isPageUp(event)"
unazko
reviewed
Aug 23, 2021
ilhan007
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus is moved on the first element of Segmented Button or last element via PageUp or PageDown keyboard key.
Related to: #3091