Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-card): exploratory testing issues #3881

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

kskondov
Copy link
Contributor

@kskondov kskondov commented Sep 9, 2021

Header and sub header match the direction in RTL
There are no console warnings in the Card section

Part of #3619

Header and sub header match the direction in RTL
There are no console warnings in the Card section

Fixes: #3619
@kskondov kskondov requested review from a team September 9, 2021 11:36
Copy link
Contributor

@georgimkv georgimkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are more points to the issue #3619 until it can be closed.
Would you edit the PR to not close the issue after this is merged?

@fifoosid fifoosid dismissed georgimkv’s stale review September 10, 2021 08:42

description is updated

@fifoosid fifoosid merged commit 75023c1 into master Sep 10, 2021
@fifoosid fifoosid deleted the ui5-card-exploratory-testing branch September 10, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants