fix(ui5-message-strip): make speech output more comprehensive #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| MESSAGE_STRIP_CLOSE_BUTTON=Information Bar Close | ||
|
|
||
| #XACT: ARIA announcement for the MessageStrip's closable state | ||
| MESSAGE_STRIP_CLOSABLE=closable |
elenastoyanovaa
approved these changes
Dec 2, 2021
MapTo0
approved these changes
Dec 2, 2021
niyap
added a commit
that referenced
this pull request
Dec 3, 2021
* fix(ui5-message-strip): make speech output more comprehensive * use uppercase
niyap
added a commit
that referenced
this pull request
Dec 3, 2021
* fix(ui5-message-strip): make speech output more comprehensive (#4416) * fix(ui5-message-strip): make speech output more comprehensive * use uppercase * fix failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple enhancements are included in that change:
-> Close button information is read out only once when button is accessed.
-> Information regarding the ui5-message-strip is more comprehensive now.
-> All the texts used are translated.
FIXES: #3447
FIXES: #4406