feat(ui5-link, ui5-breadcrumbs): add modifiers keys to click event #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously approved these changes
May 26, 2022
tsanislavgatev
previously approved these changes
May 27, 2022
packages/main/src/Link.js
Outdated
| this._onclick(event); | ||
|
|
||
| if (this.href && !event.defaultPrevented) { | ||
| const fakeEvent = new MouseEvent("click"); |
There was a problem hiding this comment.
Is fakeEvent the best name for this variable?
There was a problem hiding this comment.
If you have any suggestion, but we create event that will be dispatched through link to simulate click from the link to achieve the default behaviour of link click.
ilhan007
approved these changes
May 30, 2022
|
Hi @hardl, Just to inform you that this PR is merged. Regards, |
|
Hi @nnaydenow, Great! Looking forward to the next release ;) BR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modifier keys information to click event.