Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-carousel): correct navigation buttons behavior #5302

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

georgimkv
Copy link
Contributor

The ui5-carousel's navigation buttons now will focus the carousel after
being clicked. This avoids losing the focus when the first/last button
of the carousel dissapears when reaching the fist/last pages.
With this change, the arrow buttons will no longer retain the focus.

Fixes: #5125

The ui5-carousel's navigation buttons now will focus the carousel after
being clicked. This avoids losing the focus when the first/last button
of the carousel dissapears when reaching the fist/last pages.

Fixes: #5125
@georgimkv georgimkv requested a review from a team May 30, 2022 12:54
@georgimkv georgimkv merged commit 34027cd into master Jun 2, 2022
@georgimkv georgimkv deleted the carousel_arrows_focus branch June 2, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel Next/Previous buttons issues
2 participants