Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix redundant event dispatch #599

Merged
merged 1 commit into from
Jul 1, 2019
Merged

fix: fix redundant event dispatch #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/base/src/DOMEventHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,25 @@ const getParentDOMNode = function getParentDOMNode(node) {
return parentNode;
};

const isOtherInstanceRegistered = () => {
return window["@ui5/webcomponents-base/DOMEventHandler"];
};

const registerInstance = () => {
window["@ui5/webcomponents-base/DOMEventHandler"] = true;
};

class DOMEventHandler {
constructor() {
throw new Error("Static class");
}

static start() {
ManagedEvents.bindAllEvents(handleEvent);
// register the handlers just once in case other bundles include and call this method multiple times
if (!isOtherInstanceRegistered()) {
ManagedEvents.bindAllEvents(handleEvent);
registerInstance();
}
}

static stop() {
Expand Down