fix(i18n): use correct i18n text bundle #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Mar 17, 2023
NHristov-sap
pushed a commit
that referenced
this pull request
May 4, 2023
Co-authored-by: Nayden Naydenov <nnaydenow.work@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for fetching i18n bundles skips custom registered i18n bundles. For example if custom Hebrew translations are registered with localeId
he, they will be skipped becauseheis a new format localeId which should be mapped withiwlocaleId for compatible reasons.This PR changes the behavior to use custom bundles if they are registered, otherwise fallback logic will try to find an existing bundle one, compatible one or it will use defaults.
Fixes: #6635