Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-page): replace resize observer with container query #7995

Closed
wants to merge 1 commit into from
Closed

fix(ui5-page): replace resize observer with container query #7995

wants to merge 1 commit into from

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Dec 12, 2023

Related to: #7666

@MapTo0 MapTo0 requested review from nnaydenow and niyap December 12, 2023 21:11
@nnaydenow
Copy link
Contributor

Using container query creates new stacking context which causes positioning issues with popover. These issues are going to be fixed with the new popover attribute. In my opinion we should wait until the integration of the popover API in order to prevent future issues.

@github-actions github-actions bot added the Stale label Jan 4, 2024
@github-actions github-actions bot closed this Jan 11, 2024
@nnaydenow nnaydenow deleted the page-container-queries branch May 29, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

@niyap niyap Awaiting requested review from niyap

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MapTo0 @nnaydenow