Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-breadcrumbs): remove char separators from accessibility announcement #8099

Merged
merged 6 commits into from
Jan 17, 2024
Merged

fix(ui5-breadcrumbs): remove char separators from accessibility announcement #8099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b5daac
fix(ui5-breadcrumbs): remove char separators from accessibility annou…
kgogov Jan 12, 2024
9dd5b43
Merge remote-tracking branch 'upstream/main' into breadcrumbs-acc-imp…
kgogov Jan 15, 2024
1810c74
Merge branch 'SAP:main' into breadcrumbs-acc-improvement
kgogov Jan 16, 2024
46f4184
Merge remote-tracking branch 'upstream/main' into breadcrumbs-acc-imp…
kgogov Jan 16, 2024
d1d14a7
Merge remote-tracking branch 'upstream/main' into breadcrumbs-acc-imp…
kgogov Jan 16, 2024
2190c2a
chore: adjust edge case for failing test
kgogov Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/main/src/Breadcrumbs.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
data-ui5-stable="{{this.stableDomRef}}">
{{this.innerText}}
</ui5-link>

<span class="ui5-breadcrumbs-separator" aria-hidden="true"></span>
</li>
{{/each}}

Expand Down
44 changes: 22 additions & 22 deletions packages/main/src/themes/Breadcrumbs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,40 +73,40 @@
right: 0;
}

/* links separator */
li:not(.ui5-breadcrumbs-current-location)::after {
content: "/"; /* default separator is "Slash" */
padding: 0 .25rem;
cursor: auto;
color: var(--sapContent_LabelColor);
display: inline-block;
font-family: "72override",var(--sapFontFamily);
font-size: var(--sapFontSize);
}

.ui5-breadcrumbs-popover-footer {
display: flex;
justify-content: flex-end;
width: 100%;
}

/* separator styles */
:host([separator-style="BackSlash"]) li:not(.ui5-breadcrumbs-current-location)::after {
content: "\\";
/* links separator */
.ui5-breadcrumbs-separator::after {
content: "/"; /* default separator is "Slash" */
padding: 0 .25rem;
cursor: auto;
color: var(--sapContent_LabelColor);
display: inline-block;
font-family: "72override", var(--sapFontFamily);
font-size: var(--sapFontSize);
}

:host([separator-style="DoubleBackSlash"]) li:not(.ui5-breadcrumbs-current-location)::after {
content: "\\\\";
/* separator styles */
:host([separator-style="DoubleSlash"]) .ui5-breadcrumbs-separator::after {
content: "//";
}

:host([separator-style="DoubleGreaterThan"]) li:not(.ui5-breadcrumbs-current-location)::after {
content: ">>";
:host([separator-style="BackSlash"]) .ui5-breadcrumbs-separator::after {
content: "\\";
}

:host([separator-style="DoubleSlash"]) li:not(.ui5-breadcrumbs-current-location)::after {
content: "//";
:host([separator-style="DoubleBackSlash"]) .ui5-breadcrumbs-separator::after {
content: "\\\\";
}

:host([separator-style="GreaterThan"]) li:not(.ui5-breadcrumbs-current-location)::after {
content: ">";
:host([separator-style="GreaterThan"]) .ui5-breadcrumbs-separator::after {
content: ">";
}

:host([separator-style="DoubleGreaterThan"]) .ui5-breadcrumbs-separator::after {
content: ">>";
}
2 changes: 1 addition & 1 deletion packages/main/test/pages/Breadcrumbs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ <h2>Breadcrumbs with overflowing links</h2>
<ui5-breadcrumbs-item href="#">Link4</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="#">Link5</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="#">Link6</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item id="item7" href="#">aa</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item id="item7" href="#">aaaa</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Location</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
Expand Down