Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui5-shellbar): optimize coPilot SVG #960

Merged
merged 1 commit into from
Nov 25, 2019
Merged

refactor(ui5-shellbar): optimize coPilot SVG #960

merged 1 commit into from
Nov 25, 2019

Conversation

ilhan007
Copy link
Member

  • compress the size of animated coPilot SVG from more than 18k to 8.1k
  • unused CSS class svg-box-content removed
  • correctly fallback to non-animated SVG if the feature is not imported (there use to be a bug - throws JS error)

@ilhan007
refactor(ui5-shellbar): optimize coPilot SVG
5b6245e 
The size of the animated SVG is decreased from 18k to 8k
@ilhan007 ilhan007 merged commit 66d8c62 into master Nov 25, 2019
@ilhan007 ilhan007 deleted the refactor-optimize-coPilot branch November 25, 2019 07:14
plamenivanov91 pushed a commit to plamenivanov91/ui5-webcomponents that referenced this pull request Nov 27, 2019
@ilhan007 @plamenivanov91
refactor(ui5-shellbar): optimize coPilot SVG (SAP#960)
422a49a 
- compress the size of animated coPilot SVG from more than 18k to 8.1k
- unused CSS class `svg-box-content` removed
- correctly fallback to non-animated SVG if the feature is not imported (there use to be a bug - throws JS error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@pskelin pskelin Awaiting requested review from pskelin

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilhan007 @vladitasev