Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): adds message with severity support via inquirer-gui #763

Merged
merged 3 commits into from
May 8, 2023
Merged

feat(frontend): adds message with severity support via inquirer-gui #763

merged 3 commits into from
May 8, 2023
+49 −6

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented May 5, 2023 •
edited
Loading

  • consumes inquirer-gui@0.6.0 with messages with severity support, adds type IMessageSeverity for TS consumers
  • updates foodq with examples

@IainSAP
feat(frontend): adds message with severity support via inquirer-gui
15170ba 
consumes inquirer-gui with messages with seveity support, adds type for same
@IainSAP IainSAP self-assigned this May 5, 2023
@IainSAP IainSAP requested review from rimasirich and idoprz May 5, 2023 09:31
alex-gilin
alex-gilin requested changes May 7, 2023
View reviewed changes
Copy link
Contributor

@alex-gilin alex-gilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the file packages/backend/yeoman-ui-1.11.1.vsix.txt is added by mistake in that PR.

@IainSAP
Copy link
Contributor Author

IainSAP commented May 8, 2023

looks like the file packages/backend/yeoman-ui-1.11.1.vsix.txt is added by mistake in that PR.

Thanks @alex-gilin , file is removed now.

alex-gilin
alex-gilin approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@alex-gilin alex-gilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IainSAP IainSAP merged commit d5cbde3 into SAP:master May 8, 2023
@IainSAP IainSAP deleted the feat/add_severity_message_support branch May 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-gilin alex-gilin alex-gilin approved these changes

@rimasirich rimasirich Awaiting requested review from rimasirich

@idoprz idoprz Awaiting requested review from idoprz

Assignees

@IainSAP IainSAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IainSAP @alex-gilin