Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to install dependencies #1163

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix: unable to install dependencies #1163

merged 1 commit into from
Sep 28, 2022

Conversation

zonemeen
Copy link
Collaborator

@zonemeen zonemeen commented Sep 28, 2022

If don‘t add "private": true, won't be able to install the dependencies.

1664349708995

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 72.32% // Head: 72.32% // No change to project coverage 👍

Coverage data is based on head (ddf09a0) compared to base (0e3ef8e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files           8        8           
  Lines         159      159           
  Branches       26       26           
=======================================
  Hits          115      115           
  Misses         27       27           
  Partials       17       17           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SBoudrias SBoudrias merged commit 7ac1682 into SBoudrias:master Sep 28, 2022
@SBoudrias
Copy link
Owner

Thanks!

@LitoMore
Copy link
Collaborator

@SBoudrias What is this commit 7f27ea6 to fix for?

I noticed this but not sure if you are trying to fix another issue.

@SBoudrias
Copy link
Owner

Oh I wanted to make @inquirer/test private initially; but saw it didn't work with Lerna, and it broke the repo state being able to release. This seemed to block lerna initially; but then it didn't make sense... I thought it was due to an update.

@zonemeen zonemeen deleted the fix/install-deps branch September 30, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants