Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update for ITK 5.3.0 #23

Merged
merged 1 commit into from
Dec 9, 2022
Merged

ENH: Update for ITK 5.3.0 #23

merged 1 commit into from
Dec 9, 2022

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Dec 9, 2022

Build against stable itk-5.3.0 (includes refined Dask support among many other improvements).

Uses the new ITK remote module GitHub Action.

@thewtex thewtex requested review from jcfr and jessdtate December 9, 2022 12:44
@dzenanz
Copy link

dzenanz commented Dec 9, 2022

Warnings for Mac: https://open.cdash.org/build/8326278/configure and https://open.cdash.org/viewBuildError.php?type=1&buildid=8326278. As these links will go out of date in a month, here is a copy-paste of the warning messages:

CMake Warning (dev) at /Users/runner/work/ITKCleaver/build/_deps/cleaver_lib-src/src/lib/cleaver/CMakeLists.txt:43 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'BUILD_SHARED_LIBS'.
This warning is for project developers.  Use -Wno-dev to suppress it.

and /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: _deps/cleaver_lib-build/lib/cleaver/libitkcleaver-5.3.a(ScaledField.cpp.o) has no symbols.

@thewtex
Copy link
Member Author

thewtex commented Dec 9, 2022

and /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: _deps/cleaver_lib-build/lib/cleaver/libitkcleaver-5.3.a(ScaledField.cpp.o) has no symbols.

@tbirdso do we have a way to specify custom warning exceptions?:

        set(CTEST_CUSTOM_WARNING_EXCEPTION
          \${CTEST_CUSTOM_WARNING_EXCEPTION}
          # macOS Azure VM Warning
          "ld: warning: text-based stub file"
          "libcleaver.a.*has no symbols"
          "libitkcleaver.*has no symbols"
          )

@tbirdso
Copy link
Contributor

tbirdso commented Dec 9, 2022

do we have a way to specify custom warning exceptions?:

Hi @thewtex , I have proposed a change to allow this, would help to have your review: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#27

Build against stable itk-5.3.0 (includes refined Dask support among many
other improvements).

Uses the new ITK remote module GitHub Action.
@thewtex
Copy link
Member Author

thewtex commented Dec 9, 2022

Resolves #22

@thewtex thewtex merged commit 9c58c0f into master Dec 9, 2022
@thewtex thewtex deleted the itk-5.3.0 branch December 9, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants