-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only initialize the CLI for headless mode and add Dockerfile #2438
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Georgia Stuart <georgia.staurt@gmail.com>
Signed-off-by: Georgia Stuart <georgia.staurt@gmail.com>
Signed-off-by: Georgia Stuart <georgia.staurt@gmail.com>
Signed-off-by: Georgia Stuart <georgia.staurt@gmail.com>
Signed-off-by: Georgia Stuart <georgia.staurt@gmail.com>
I also just pushed a tweak to the docs. Ubuntu 22.04 and later needs different QT5 package names, and I found that I needed to use |
Thank you for the Docker file, that was a long-needed feature. I'll check the Windows and Mac builds and then we can probably merge this. |
Here's the issue, only 7 years old #1720 |
Signed-off-by: Georgia Stuart <georgia.staurt@gmail.com>
I think the mac build failed because of the |
We might need 4.1 to fix the failure https://github.com/jurplel/install-qt-action/releases/tag/v4.1.0 |
Hmm, |
According to https://github.com/orgs/community/discussions/48058 and https://github.com/jurplel/install-qt-action/tags, I think in this case it's using the older 4.0.0 tag, and the error looks exactly like 4.1.0's fix. I thought it would grab the latest too, but it seems to be repo-specific. Good to see SCIRun's rusty wheels getting some exercise, at least. |
While you're updating action versions, would you mind bumping upload-artifact too? https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ |
I think it is pulling 4.1, that MacOS update refers to this removed brew install, not the pip install: jurplel/install-qt-action@cb07ed2 . I think the Looks like it's this and the fix is to let the action manage python, which seems OK since SCIRun builds its own Python: jurplel/install-qt-action#239 Updating that and the request above. |
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Hah I hope you're OK with using this PR as a github action cleanup opportunity. The new Mac error is this old line that should not be needed anymore: https://github.com/SCIInstitute/SCIRun/pull/2438/files#diff-38c2966d1144b82978ca2cfe7650879fb15bd6da5845a3c616e8d152b29317f1R90 It was added in 2019 probably to fix some other problem (the commit message gave no details), so it can be deleted. It's in four places in the mac yml file. |
Co-authored-by: Dan White <functoire@gmail.com>
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Np on the cicd cleanup opportunity! I removed the symlink lines and (I think) fixed the Windows Qt6 error (the Qt6_PATH env var is no longer set by the install action it looks like). If y'all have a place to park a Docker image, I can throw in a Docker build workflow. Right now I build and host the container (internally) on our GitLab instance. |
- name: Prepare | ||
run: | | ||
ln -s /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/Tk.framework/Versions/8.5/Headers/X11/ /usr/local/include/X11 | ||
|
||
- name: make | ||
run: ./build.sh -DQt_PATH="${Qt5_Dir}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress! Now the configure is failing, this should be changed to ${Qt_dir}
or path or whichever it is now...
For now you could try putting something here, I just created it: https://hub.docker.com/repository/docker/functoire/scirun/general |
Meanwhile the headless Mac build is failing in Boost code, which would require an upgrade to Boost 1.86. Now that I don't expect you to do, unless you really want to take over as a maintainer... |
I've been helping a group use SCIRun on our local cluster. As part of that work, I made a couple changes to SCIRun that may be useful to others. Namely...
-x
was specified, since QT always tried to identify a display. To solve this, I added a check for-x
or-h
to the Main function to initialize the command line program instead.Seems to work fine locally. Tested on an Ubuntu 24.04 system using the Apptainer runtime from a docker image.