bboxWrap correction #108
Merged
bboxWrap correction #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsmith
requested changes
Jul 15, 2024
cwsmith
reviewed
Jul 15, 2024
|
/runtests |
|
Test Result: failure (details) |
cwsmith
requested changes
Jul 15, 2024
|
/runtests |
cwsmith
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bbcxWrap()was initialized with zero, resulting inget_bounding_boxorfind_bounding_boxgiving wrong answers when the mesh lives on only one side of an axis. Instead of zero, I usedKokkos::Experimental::finite_min_vandfinite_max_vformaxandminrespectively. I also added two test cases for bbox inunit_mesh.cpp.