Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qla2x00t-32gbit to Linux Kernel v6.4 #166

Merged
merged 3 commits into from
Jun 5, 2023

Commits on May 10, 2023

  1. qla2x00t-32gbit: Drop redundant pci_enable_pcie_error_reporting()

    pci_enable_pcie_error_reporting() enables the device to send ERR_*
    Messages.  Since commit f26e58bf6f54 ("PCI/AER: Enable error reporting when
    AER is native"), the PCI core does this for all devices during enumeration,
    so the driver doesn't need to do it itself.
    
    Remove the redundant pci_enable_pcie_error_reporting() call from the
    driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
    from the driver .remove() path.
    
    Note that this only controls ERR_* Messages from the device.  An ERR_*
    Message may cause the Root Port to generate an interrupt, depending on the
    AER Root Error Command register managed by the AER service driver.
    
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Link: https://lore.kernel.org/r/20230307182842.870378-10-helgaas@kernel.org
    Cc: Nilesh Javali <njavali@marvell.com>
    Cc: GR-QLogic-Storage-Upstream@marvell.com
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    [ commit c5c440bbff86 upstream ]
    lnocturno committed May 10, 2023
    Configuration menu
    Copy the full SHA
    a397c70 View commit details
    Browse the repository at this point in the history
  2. qla2x00t-32gbit: Backport to older kernel versions

    Backport the change from a previous commit to kernel versions prior to
    v6.0, where commit f26e58bf6f54 ("PCI/AER: Enable error reporting when
    AER is native") hasn't been introduced.
    lnocturno committed May 10, 2023
    Configuration menu
    Copy the full SHA
    1d2a0b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. qla2x00t-32gbit: Fix NULL pointer dereference in target mode

    When target mode is enabled, the pci_irq_get_affinity() function may return
    a NULL value in qla_mapq_init_qp_cpu_map() due to the qla24xx_enable_msix()
    code that handles IRQ settings for target mode. This leads to a crash due
    to a NULL pointer dereference.
    
    This patch fixes the issue by adding a check for the NULL value returned by
    pci_irq_get_affinity() and introducing a 'cpu_mapped' boolean flag to the
    qla_qpair structure, ensuring that the qpair's CPU affinity is updated when
    it has not been mapped to a CPU.
    
    Fixes: 1d201c81d4cc ("scsi: qla2xxx: Select qpair depending on which CPU post_cmd() gets called")
    Signed-off-by: Gleb Chesnokov <gleb.chesnokov@scst.dev>
    Link: https://lore.kernel.org/r/56b416f2-4e0f-b6cf-d6d5-b7c372e3c6a2@scst.dev
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    [ commit d54820b22e40 upstream ]
    
    Fixes: #156
    lnocturno committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    51bf7ea View commit details
    Browse the repository at this point in the history