decodedImageWithImage solve the problem CGBitmapContextCreate

[LilyHZ]

CGBitmapContextCreate: unsupported parameter combination: 8 integer bits/component; 16 bits/pixel; 1-component color space; kCGImageAlphaPremultipliedFirst; 128 bytes/row.
CGContextDrawImage: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.
answer:

• (UIImage *)decodedImageWithImage:(UIImage *)image {
  @autoreleasepool{
  // do not decode animated images
  if (image.images) { return image; }

  UIGraphicsBeginImageContextWithOptions(image.size, NO, image.scale); {
      CGRect imageRect = (CGRect){ CGPointZero, image.size };
      CGRect borderRect = CGRectInset(imageRect, 1, 1);
      UIBezierPath *path = [UIBezierPath bezierPathWithRoundedRect:borderRect
                                                 byRoundingCorners:UIRectCornerAllCorners
                                                       cornerRadii:CGSizeMake(0, 0)];
      [path addClip];
      [image drawAtPoint:CGPointZero];
  }
  UIImage *roundedImage = UIGraphicsGetImageFromCurrentImageContext();
  UIGraphicsEndImageContext();
  return roundedImage;
  

  }

[mythodeia]

@LilyHZ are you using the latest version? the code you have posted is not in the decodedImageWithImage method

[a13xb]

@mythodeia I see the same with 3.7.4 decoding a PNG image:

CGBitmapContextCreate: unsupported parameter combination:
    16 integer bits/component;
    64 bits/pixel;
    RGB color space model; kCGImageAlphaPremultipliedFirst;
    1024 bytes/row.
Valid parameters for RGB color space model are:
    16  bits per pixel,      5  bits per component,      kCGImageAlphaNoneSkipFirst
    32  bits per pixel,      8  bits per component,      kCGImageAlphaNoneSkipFirst
    32  bits per pixel,      8  bits per component,      kCGImageAlphaNoneSkipLast
    32  bits per pixel,      8  bits per component,      kCGImageAlphaPremultipliedFirst
    32  bits per pixel,      8  bits per component,      kCGImageAlphaPremultipliedLast
    64  bits per pixel,      16 bits per component,      kCGImageAlphaPremultipliedLast
    64  bits per pixel,      16 bits per component,      kCGImageAlphaNoneSkipLast
    128 bits per pixel,      32 bits per component,      kCGImageAlphaNoneSkipLast |kCGBitmapFloatComponents
    128 bits per pixel,      32 bits per component,      kCGImageAlphaPremultipliedLast |kCGBitmapFloatComponents
See Quartz 2D Programming Guide (available online) for more information.

[mythodeia]

@a13xb can you please share that image?

[a13xb]

@mythodeia

[mythodeia]

@a13xb i will take a look at it thanks

[mythodeia]

the error you are getting is:
unsupported parameter combination: 64 bpp RGB color space model; kCGImageAlphaPremultipliedFirst

according to the following table:
this combination is not supported.

[a13xb]

@mythodeia Yes, it's not supported, but it happens when SDWebImage creates output context with the wrong pixel format, taking some parameters from input image, hardcoding other parameters, so sometimes they don't match.

Moreover, this image used to work on previous versions of SDWebImage, so it's definitely a regression.

[mythodeia]

@a13xb i will take a closer look later today. 👍

[mythodeia]

@a13xb if you replace CGImageGetBitsPerComponent(imageRef) with 8 it works fine. but i cannot hardcode this for these kind of images. A better solution would be to check if the bits per component result in an unsupported combination and if it does then roll back to hardcoded 8.
pull requests are always welcome :P

[mythodeia]

@a13xb does this pull solve your issues? #1496

[mythodeia]

fixed #1496