crash in 3.8.0 and 3.8.1 from many users #1608
Comments
|
We have also plenty of exactly the same crashes. It started to happen after updating to a version with NSURLSession |
|
@smogun have you manage to reproduce it, I am wondering if that's relevant to the url query changes which were revered in 3.8.1 and if it fixes the crash? |
|
Confirm. After updating to 3.8.1 (from 3.7.6) getting lots of crashes with same reason: Interesting that all crashes even don't have SDWebImage in the stack trace so found that ticket only after investigation what I updated since previous version so getting so many crashes. Don't think it's a coincidence. |
|
i am just curios if it is safe to downgrade to 3.7.6 |
romk1n
changed the title
|
luckily I had this happen while I was debugging. here's the output of |
|
Same here from Fabric/Crashlytics for multiple users : |
|
I have the same issues too. |
|
I will look at this issue asap. Looks like more than an isolated issue |
|
I'm also having this issue. Critical. Downgraded to 3.7.6. |
|
I got same issue too. |
|
Same for me too. Next time it happens I will try to debug a bit and see if I can find out something useful. |
|
Hope anyone can try this #1623 (comment) , I just can't reproduce the crash by myself. |
|
Hi guys, Same problem (3.8.1) Any updates about it? Thanks! |
|
I will take a proper look at this issue this weekend. |
|
I have spent some time trying to figure this out, but without success. |
|
PS: @bsjcho thanks for the extra info |
|
@bpoplauschi Yes, of course. Use this link to see crash: http://crashes.to/s/ddb48c8cc47 |
|
Many thanks @DarkDarius. It seems my assumption was wrong. In your crashlog, there is no other thread working with the Another thing I tried was to pass nil to Another idea is that somehow, the |
|
@bpoplauschi here the one i found http://crashes.to/s/4af2fa1f4c7 |
|
Thanks @romk1n |
bpoplauschi
added a commit
that referenced
this issue
Sep 1, 2016
…id using the `_request` ivar and made sure we strip request of mutability
|
Guys, I'm in a bit of dead-end here. I need help. I've added 1 commit on master with a small change, could you try it and see if the issue still occurs? Also, if anyone can reproduce the issue constantly, could you create a small demo project so I can debug it properly? (maybe @bsjcho) Note: I was able to simulate the same crashlog by using a deallocated instance of |
bpoplauschi
added a commit
that referenced
this issue
Sep 5, 2016
…e cases. Apparently there is a race condition on NSURLCache and we avoid making those checks unless necesarry (basically we will query the NSURLCache only when `SDWebImageRefreshCached` is used and the image cannot be cached by the system when it's too big or behind authentication)
|
I have made an attempt fix in e7bd5ab: Apparently there is a race condition on |
|
Guys, 3.8.2 is now available via CocoaPods, please try it out and let me know if the issue still happens or not. |
|
@bpoplauschi Did you file a radar on that race condition in |
|
@kaspermunck I did not create a radar, as I am not sure that is the cause. I'm waiting for people that had the issue and upgraded to comment back, if it's fixed. Basically, I only reduced the number of calls to |
|
Dug a little deeper (i.e. actually studied the documentation of NSURLCache) and unfortunately it looks like the race condition is expected in certain cases (read more here). |
8 tasks
|
Thanks to @zaczh, this issue will entirely go away in version 4.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New Issue Checklist
Issue Info
Issue Description and Steps
We have Fabric reporting a lot of the crashes
Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.
The text was updated successfully, but these errors were encountered: