add SD_APP_EXTENSION macro for ios8 extensions #953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define the SD_APP_EXTENSION preprocessor macro when you are building an extension that includes SDWebImage. This avoids compile time errors about the user of [UIApplication sharedApplication]
|
Any reason this hasn't been merged yet? It won't affect existing users at all. I'd say a simple note in the documentation that the developer is responsible for calling cleanup within an extension should suffice for now. |
|
Note: this also happens when you build the library as a framework with the new version of CocoaPods (and try to use it in an extension), so it's likely about to become a bigger problem for people. |
|
+1 |
1 similar comment
|
+1 |
|
Any plans on when this will be added? As AppBoy has a direct dependency to SdWebImage, we are forced to stay behind on a buggy cocoa pods version as SDWebImage cannot build for extensions. Would be great to hear from you! |
|
closing this. this 91b4251 was already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define the SD_APP_EXTENSION preprocessor macro when you are building an extension that includes SDWebImage. This avoids compile time errors about the user of [UIApplication sharedApplication]
Addresses: #859