Now it's time to move to Lottie 3.4, which solve the performance issue #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2022
Closed
Pick back the code, and implements the bitmap frame extract using the new API
dreampiggy
force-pushed
the
1.x
branch
4 times, most recently
from
6704ef2 to
2dc5856
Compare
|
LGTM now. Have no time to fix the GitHub Action CI, just test locally
|
…upstream bug) Seems a lie that you can use Lottie 3 from Objc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick back the code, and implements the bitmap frame extract using the new API (That
LottieCompositionLayer)And during the development, I found a bad design that
SDAnimatedImageView.sd_setImage(with:)hardcode the.animatedImageClasstoSDAnimatedImage.self. It's not easy to use.This will be fixed in SDWebImage v5.13.1 as well.