Fix the issue when WebP is static webp, the SDAnimatedImageCoder protocol implementation still create CGContext, this can reduce RAM usage
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otocol implementation still create CGContext, this can reduce RAM usage
8 tasks
Almouro
added a commit
to Almouro/react-native-fast-image
that referenced
this pull request
Feb 6, 2020
This improves RAM usage for static webp assets (see SDWebImage/SDWebImageWebPCoder#30) Potentially related to DylanVann#622
DylanVann
pushed a commit
to DylanVann/react-native-fast-image
that referenced
this pull request
Mar 14, 2020
This improves RAM usage for static webp assets see: SDWebImage/SDWebImageWebPCoder#30 Potentially related to #622
connoremma
pushed a commit
to gametimesf/react-native-fast-image
that referenced
this pull request
May 11, 2020
This improves RAM usage for static webp assets see: SDWebImage/SDWebImageWebPCoder#30 Potentially related to DylanVann#622
alicayan008
pushed a commit
to alicayan008/ReactNative-fast-image
that referenced
this pull request
Jul 4, 2023
This improves RAM usage for static webp assets see: SDWebImage/SDWebImageWebPCoder#30 Potentially related to DylanVann/react-native-fast-image#622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for #29.
For Static WebP, we don't create extra CGContext to consume RAM. Instead, just do the static WebP decoding.
Note this method still need to be protected in the LOCK/UNLOCK code, because multiple thread can access the
animatedImageFrameAtIndex:, and we share the global_demuxinstance.The root solution is in 5.4.2 of SDWebImage, see: SDWebImage/SDWebImage#2924