Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue in Unit Tests (tests.test_seacrowd_source_only and tests.test_seacrowd) #42

Closed
sabilmakbar opened this issue Nov 12, 2023 · 0 comments · Fixed by #44
Closed
Assignees

Comments

@sabilmakbar
Copy link
Collaborator

Hi, looks like the docstring and comments in template doesn't provide a clear instruction on what values to fill on [seacrowd_schema_name], esp when compared against expected values in unit-tests provided in tests folder

Here's the line(s) that I'm referring to in templates/template.py:

  1. 1st miss in templates/template.py
  2. 2nd miss in templates/template.py

And from debugging the issue, the expected values of seacrowd_schema_name from tests script, it follows the constants defined in constant.py

Can we confirm whether it's expected to throw an error or not?

holylovenia added a commit that referenced this issue Nov 13, 2023
Closes #42 | Fix guide related to seacrowd_schema_name in templates
@sabilmakbar sabilmakbar self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant