Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #29 | Add dataset loader for IJELID #45

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

ljvmiranda921
Copy link
Collaborator

@ljvmiranda921 ljvmiranda921 commented Nov 14, 2023

Closes #29

Notes:

  • IJELID is a token-level language identification task. I can't seem to find it in the supported tasks so I added a new one in this PR (b472a1c)

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@ryanignatius ryanignatius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and tested,
LGTM

@yongzx
Copy link
Collaborator

yongzx commented Nov 19, 2023

The dataloader runs (data = load_dataset("seacrowd/sea_datasets/ijelid/ijelid.py")) without needing to specify config name. Is this intended? @ljvmiranda921

@yongzx
Copy link
Collaborator

yongzx commented Nov 19, 2023

reviewed and tested as well.

@ljvmiranda921
Copy link
Collaborator Author

Thanks for the reviews @ryanignatius and @yongzx !
As for the load_dataset question, it automatically loads the DEFAULT_CONFIG_NAME (in this case, ijelid_souce) when nothing's passed to the name parameter.

@SamuelCahyawijaya SamuelCahyawijaya merged commit 68e34f7 into SEACrowd:master Nov 20, 2023
1 check passed
@ljvmiranda921 ljvmiranda921 deleted the add/ijelid branch November 20, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for IJELID
4 participants