Magnetometer filter warning modified #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## v1.13.1_dev #53 +/- ##
==============================================
Coverage ? 58.71%
==============================================
Files ? 957
Lines ? 83029
Branches ? 0
==============================================
Hits ? 48748
Misses ? 34281
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DavidPaddy97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In short, each mag has its own filter (implemented by us), and that warning flags when any of the mag filters are disabled due to sampling too slowly. Therefore the CAN mags will continue flagging this every 10s even though we're using the I2C mag which is working properly with its filter.
Solution
Initially this warning would trigger every 10s (one generic 'warning_last' that covers all mags) if any of the mags were being filtered inappropriately (leading to disabling of its filter). Now, the warning only triggers for the primary magnetometer. The functionality of the filters does not change, only which magnetometer the pilot is alerted to when its filter fails.
Additional Changes
Updated the macOS environment version to macOS-11 as macOS-10.15 tests would queue but no worker would be assigned.
Suspected due to actions/runner-images#5583