RC Connected Status Indicator Fix #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardHopkirk
approved these changes
Apr 4, 2024
mjbcopland
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Switching backuplink RC status indicator * Correcting variable name * Fixing comment
mjbcopland
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Switching backuplink RC status indicator * Correcting variable name * Fixing comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is interlinked with these:
For more detail, refer to those.
In short, we are now looking at the number of RC connections providing setpoints (joystick connected) to determine if local RC is connected. We were previously looking at the rc signal_lost flag in PX4, but this does not always work.