This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Clean POM layout #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| !/.mvn/wrapper/maven-wrapper.jar |
There was a problem hiding this comment.
Do we want to give students such an extensive .gitignore?
There was a problem hiding this comment.
Do you mean with the IDE files included?
There was a problem hiding this comment.
I personally believe it will mess up quite a few Git timelines if we don't add the ignore for IDE files now... But if you think it's too much, I'll remove it and they can use their Git skill to find it back :P
There was a problem hiding this comment.
After a (real life) discussion, we have decided it is better to remove these changes and leave it to the students to find it back if they really want to.
mjwsteenbergen
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a bit of spacing to the POM file and, more importantly, this PR sets the java compiler versions to 1.8 properly.
Motivation and Context
I found the properties in the POM were not properly linked to the dependencies (including compiler level).
How Has This Been Tested?
mvn clean installhas been run to confirm proper installation is possible. This included the tests. Alsomvn sitewas run after this. Both runs succeeded.Checklist: