Cleanup of error logging in gold_master.py and Galileo SSI #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains fixes to how errors are logged. It was part of the previous pull request but that one got merged before I had pushed these changes.
In the LOGGING methods in
oops/config.py
:print()
, literal messages no longer get counted as warnings or errors, even if the level is WARN or ERROR. This is consistent with the point of literal messages, which is to add supplementary info to the log. Supplementary info about a warning or error should not increment the count.In
oops/gold_master/__init__.py
:define_standard_obs()
.LOGGING.pop()
is always called afterLOGGING.push()
using try/finally.For Galileo SSI:
define_standard_obs()
, taking advantage of the new input defaults.