Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Example (Global Allocator) - Revised comments #20

Merged
merged 2 commits into from
Dec 6, 2023
Merged

docs: Example (Global Allocator) - Revised comments #20

merged 2 commits into from
Dec 6, 2023

Conversation

polarathene
Copy link
Contributor

Just a little bit of revision if you like the phrasing any better.

Main motivation was the Span::from_array comment.

  • It looks like the variable needed to be updated and the associated comment could better communicate the alternative with two lines.
  • For some reason it didn't catch my attention when you originally suggested it.

SFBdragon
SFBdragon requested changes Dec 6, 2023
View reviewed changes
examples/std_global_allocator.rs Outdated Show resolved Hide resolved
@polarathene @SFBdragon
chore: Apply review feedback
6c14b19 
Co-authored-by: Shaun Beautement <sf.beautement@protonmail.com>
@polarathene polarathene requested a review from SFBdragon December 6, 2023 21:01
@polarathene
Copy link
Contributor Author

Much better, thanks! :)

SFBdragon
SFBdragon approved these changes Dec 6, 2023
View reviewed changes
Copy link
Owner

@SFBdragon SFBdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :)

@SFBdragon SFBdragon merged commit 485cdd6 into SFBdragon:master Dec 6, 2023
@SFBdragon SFBdragon mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SFBdragon SFBdragon SFBdragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polarathene @SFBdragon