Use email for Github Actions bot #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our company's tooling retrieves a list of commits for each pull request and checks whether the commit's author has signed a Contributor License Agreement. It filters bot accounts by checking the `type` property for the string ["Bot"]. However, commits made using the GITHUB_ACTIONS token are showing up as `type` "User". This is [WAD], however. The workaround is to use the bot's ID to prefix the email address. See: actions/checkout/#1184 ["Bot"]: https://github.com/salesforce/dr-cla/blob/290a3a1d/app/utils/GitHub.scala#L515-L519 [WAD]: https://github.com/orgs/community/discussions/26560#discussioncomment-3252337
jofsky
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our company's tooling retrieves a list of commits for each pull request
and checks whether the commit's author has signed a Contributor License
Agreement. It filters bot accounts by checking the
typeproperty forthe string "Bot". However, commits made using the GITHUB_ACTIONS token
are showing up as
type"User". This is WAD, however. The workaroundis to use the bot's ID to prefix the email address.
See: actions/checkout#1184