Fix android delete/backspace keycodes... #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correspsonding commit to this in the SFML repo: SFML/SFML@1862946
|
Thank you! It's great that it means less #ifdef's for ImGui-SFML. :) |
|
With the release of SFML 2.5.0 it|s time to be merged. |
|
I'll merge this soon. I think I'll make ifdef for SFML <= 2.5 and later I'll remove it once I'm sure that most people are using SFML 2.5. :) |
Alia5
changed the title
eliasdaler
pushed a commit
that referenced
this pull request
Nov 12, 2021
Previously SFML used wrong keycodes for backspace/delete keys - was fixed in SFML 2.5.
|
Finally merged in 7444659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correspsonding commit to this in the SFML repo: SFML/SFML@1862946
If you want to support current SFML versions, I think it's best not to merge yet.
I'll leave this here however if people decide to build from SFML master.