Add a Python argparse option to supply additional DLL search paths for Windows #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanqn
force-pushed
the
add-dll-paths
branch
from
01297cb
to
3c5bdb6
Compare
heinezen
approved these changes
Sep 25, 2021
heinezen
requested changes
Sep 25, 2021
openage/game/main.py
Outdated
| @@ -30,6 +30,13 @@ def main(args, error): | |||
| """ | |||
| del error # unused | |||
|
|
|||
| win_dll_path_handles = [] | |||
| import sys | |||
There was a problem hiding this comment.
This can probably be a top-level import now that we use it twice or more ^^
heinezen
previously approved these changes
Sep 25, 2021
|
One last thing: kevin complains about the import order :D |
…Windows (requires Python 3.8+)
duanqn
force-pushed
the
add-dll-paths
branch
from
a5a442c
to
2ee3d74
Compare
heinezen
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in https://docs.python.org/3/library/os.html#os.add_dll_directory, Python 3.8+ on Windows uses DLL paths added with
os.add_dll_directory, and the PATH is not used.