Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modpack load fixes #1579

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Modpack load fixes #1579

merged 3 commits into from
Oct 17, 2023

Conversation

heinezen
Copy link
Member

Improves modpack loading a bit

  • Clarify difference between version and versionstr in modpack info file
  • Fix engine modpack export via CLI
  • Replace a usage of std::string::substr() with a constant string

This is a cherry-picked version of #1574 without the changes to the engine modpack version.

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code lang: python Done in Python code bugfix Restores intended behavior labels Oct 15, 2023
@TheJJ TheJJ merged commit 5fcd3d7 into SFTtech:master Oct 17, 2023
8 of 13 checks passed
@heinezen heinezen deleted the fix/modpack-load-v2 branch October 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
bugfix Restores intended behavior improvement Enhancement of an existing component lang: c++ Done in C++ code lang: python Done in Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @TheJJ