Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary file/directory creation #1594

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Temporary file/directory creation #1594

merged 2 commits into from
Nov 1, 2023

Conversation

Ashhar-24
Copy link
Contributor

Completed following two tasks of issue #1540

  • Create temp file/dir and wrap them in openage file system API
  • Delete temp file/dir explicitely when object is destroyed

heinezen
heinezen requested changes Oct 30, 2023
View reviewed changes
openage/util/fslike/path.py Outdated Show resolved Hide resolved
Ashhar-24
Ashhar-24 commented Oct 30, 2023
View reviewed changes
Copy link
Contributor Author

@Ashhar-24 Ashhar-24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the changes as asked. @heinezen

heinezen
heinezen requested changes Oct 31, 2023
View reviewed changes
openage/util/fslike/path.py Outdated Show resolved Hide resolved
openage/util/fslike/path.py Outdated Show resolved Hide resolved
@heinezen heinezen added the hacktoberfest-accepted For accepted PRs for Hacktoberfest event label Oct 31, 2023
@heinezen heinezen changed the title Issue #1540, first two tasks Temporary file/directory creation Nov 1, 2023
@heinezen heinezen merged commit a630ff3 into SFTtech:master Nov 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen heinezen approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted For accepted PRs for Hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashhar-24 @heinezen