Frustum culling #1642

nikhilghosh75 · 2024-04-26T03:42:54Z

Implemented Frustum Culling into the renderer. Currently only applies to the world renderer. The camera has a frustum data structure to allow it to cull objects outside the frustum.

An additional stresstest has been created for the renderer to test out frustum culling.

Additional fixes to loading files on windows that have the special \r character are also included in this pull request.

heinezen · 2024-04-27T01:46:00Z

Nice, I'll take a look over the weekend :)

libopenage/renderer/camera/camera.cpp

libopenage/renderer/camera/camera.h

libopenage/renderer/camera/camera.cpp

libopenage/renderer/camera/camera.h

heinezen · 2024-04-29T19:28:55Z

libopenage/renderer/resources/parser/parse_sprite.cpp

-		// Skip empty lines and comments
-		if (line.empty() || line.substr(0, 1) == "#") {
+		// Skip empty lines, lines with carriage returns, and comments
+		if (line.empty() || line.substr(0, 1) == "#" || line[0] == '\r') {


same here, these should be removed by the string splitter

heinezen · 2024-04-29T19:29:05Z

libopenage/renderer/resources/parser/parse_terrain.cpp

-		// Skip empty lines and comments
-		if (line.empty() || line.substr(0, 1) == "#") {
+		// Skip empty lines, lines with carriage returns, and comments
+		if (line.empty() || line.substr(0, 1) == "#" || line[0] == '\r') {


heinezen · 2024-04-29T19:29:13Z

libopenage/renderer/resources/parser/parse_texture.cpp

@@ -56,6 +56,11 @@ std::string parse_imagefile(const std::vector<std::string> &args) {
 	// it should result in an error if wrongly used here.

 	// Call substr() to get rid of the quotes
+	// If the line ends in a carriage return, remove it as well
+	if (args[1][args[1].size() - 1] == '\r') {


heinezen · 2024-04-29T19:29:20Z

libopenage/renderer/resources/parser/parse_texture.cpp

-		// Skip empty lines and comments
-		if (line.empty() || line.substr(0, 1) == "#") {
+		// Skip empty lines, lines with carriage returns, and comments
+		if (line.empty() || line.substr(0, 1) == "#" || line[0] == '\r') {


heinezen · 2024-04-29T19:31:32Z

libopenage/renderer/stages/world/render_stage.cpp

@@ -58,6 +58,10 @@ void WorldRenderStage::update() {
 	std::unique_lock lock{this->mutex};
 	auto current_time = this->clock->get_real_time();
 	for (auto &obj : this->render_objects) {
+		if (!obj->within_camera_frustum(this->camera)) {
+			continue;


This will still render the object btw, it just skips the update :D

I'll have to fix this in a separate PR as it is not possile right now to remove specific objects from the render pass.

heinezen · 2024-04-29T19:34:08Z

I only found a few minor issues with this and a have restructering reques. It already looks quite nice! You also have to rebase and resolve the merge conflicts.

heinezen · 2024-04-29T19:39:03Z

copying.md

@@ -153,6 +153,7 @@ _the openage authors_ are:
 | Astitva Kamble              | askastitva                  | astitvakamble5 à gmail dawt com                   |
 | Haoyang Bi                  | AyiStar                     | ayistar à outlook dawt com                        |
 | Michael Seibt               | RoboSchmied                 | github à roboschmie dawt de                       |
+| Nikhil Ghosh                | NikhilGhosh75               | nghosh606 à gmail dawt com


I think the CI fails because you are missing an | at the end of the table. Then the mailmap entry is also not necessary.

TheJJ

can't we calculate a containing circle for each object on creation and when resizing it? then we only have to check one coordinate/distance for each object to cull it.

heinezen · 2024-05-02T18:16:10Z

can't we calculate a containing circle for each object on creation and when resizing it? then we only have to check one coordinate/distance for each object to cull it.

I think that would be a bit more complicated since we would have to calculate it for every animation sprite and not just per object. And then we also have to apply zoom scaling...

heinezen · 2024-07-10T19:38:10Z

I'm gonna take this over to fix all problems and make it mergeable.

TheJJ · 2024-07-11T08:23:59Z

for every animation sprite and not just per object. And then we also have to apply zoom scaling...

how is the object size calculated currently? checking the current sprite sizes every frame? then we could do from the maximum of all its sprites instead during load? and the zooming we need anyway? :)

heinezen · 2024-07-12T00:52:39Z

how is the object size calculated currently? checking the current sprite sizes every frame? then we could do from the maximum of all its sprites instead during load? and the zooming we need anyway? :)

It's done in the shader. The size is a combination of scalefactor (from the animation), size (from the texture), and zoom (from the camera). Calculating max_size from all sizes at load is probably a good idea. This would then become a bounding box that we can multiply with sscalefactor and zoom in the renderer.

heinezen · 2024-07-15T20:55:35Z

Okay the code should now work for 3D frustum culling. I will now add an optimized version for 2D sprites as @TheJJ suggested and a demo for showing off the functionality.

Needed the current `time` for getting the correct position.

heinezen · 2024-07-21T21:57:45Z

Almost everything should be ready feature-wise now. It's just documentation for the frustum usage & architecture that is missing.

heinezen · 2024-07-21T22:01:48Z

I disabled frustum culling for now, since it's not that performant right now. Currently, it just skips the uniform update, but checking the frustum is much more expensive than performing the uniform update by itself. To make the frustum culling worth our while, we should also exclude the renderables from the draw calls. This would require us to build the list of renderables every frame which can come with its own drawbacks.

heinezen requested changes Apr 29, 2024

View reviewed changes

heinezen reviewed Apr 29, 2024

View reviewed changes

heinezen added area: renderer Concerns our graphics renderer nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code labels Apr 29, 2024

TheJJ reviewed May 2, 2024

View reviewed changes

heinezen self-assigned this Jul 10, 2024

heinezen force-pushed the frustum-culling branch 3 times, most recently from 6522a7d to 144485a Compare July 15, 2024 01:23

heinezen force-pushed the frustum-culling branch 5 times, most recently from 67cf2d1 to ae95823 Compare July 21, 2024 21:55

nikhilghosh75 added 8 commits July 21, 2024 23:56

Fixed bug with opening files with \r on windows

ad6a870

Implemented frustum culling

07e7c62

Implemented stresstest 1

e463962

Added additional comments to the frustum culling logic

84fa57b

Fixed styling

94f9a46

Fixed various checks

e62b1b9

Added name to mailmap

d70ae7f

Added name to copying.md

03da156

heinezen added 21 commits July 21, 2024 23:56

Fix name parsing in copying.md

c3805cd

renderer: Fix camera unifs for stresstest 1.

9446165

renderer: Get frustum from camera.

acc9c96

renderer: Fix object position fetching.

34cc059

Needed the current `time` for getting the correct position.

renderer: Fix position curve in stresstest 1.

5f95f21

etc: Fix time pretty print for Keyframe.

69841ad

renderer: Resize frustum to exact camera boundaries.

0df247c

renderer: Fetch updates before checking that object is in frustrum.

189d916

renderer: Move camera constants to different file.

f114994

renderer: Construct frustum with parameters.

f3365cf

renderer: Rename Frustum class to Frustum3d.

d88fb47

renderer: 2D Frustum implementation.

6926049

renderer: Get max bounds for animations.

0c0efa6

renderer: Create 2D frustum for sprites.

7391bc2

renderer: Replace 3D frustum with 2D frustum in world renderer.

769154b

renderer: Use correct zoom value for 2D frustum.

d7a8e5b

renderer: Zig-zag movement in and out of camera view in stressttest 1.

33021dc

renderer: Construct camera frustumson the fly.

04bf89e

renderer: Skip scaled vector creation in frustum.

8edeb9d

renderer: Inclide model matrix in 2D frustum check.

b457b87

renderer: Enable frustum culling with flag in world stage.

e97a944

heinezen force-pushed the frustum-culling branch from ae95823 to eed0401 Compare July 21, 2024 21:56

heinezen added 2 commits July 22, 2024 00:02

renderer: Enable GL_LINE_LOOP vertex primitive.

a608d26

renderer: Frustum culling demo.

8ba6a75

heinezen force-pushed the frustum-culling branch from eed0401 to 8ba6a75 Compare July 21, 2024 22:02

TheJJ approved these changes Jul 24, 2024

View reviewed changes

TheJJ merged commit 267670b into SFTtech:master Jul 24, 2024
13 checks passed

heinezen mentioned this pull request Aug 3, 2024

Remove string splits with \r from renderer resource parsers #1666

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Frustum culling #1642

Frustum culling #1642

nikhilghosh75 commented Apr 26, 2024

heinezen commented Apr 27, 2024

heinezen Apr 29, 2024

heinezen Apr 29, 2024

heinezen Apr 29, 2024

heinezen Apr 29, 2024

heinezen Apr 29, 2024

heinezen commented Apr 29, 2024 •

edited

Loading

heinezen Apr 29, 2024

TheJJ left a comment

heinezen commented May 2, 2024

heinezen commented Jul 10, 2024

TheJJ commented Jul 11, 2024 •

edited

Loading

heinezen commented Jul 12, 2024

heinezen commented Jul 15, 2024

heinezen commented Jul 21, 2024 •

edited

Loading

heinezen commented Jul 21, 2024

Frustum culling #1642

Frustum culling #1642

Conversation

nikhilghosh75 commented Apr 26, 2024

heinezen commented Apr 27, 2024

heinezen Apr 29, 2024

Choose a reason for hiding this comment

heinezen Apr 29, 2024

Choose a reason for hiding this comment

heinezen Apr 29, 2024

Choose a reason for hiding this comment

heinezen Apr 29, 2024

Choose a reason for hiding this comment

heinezen Apr 29, 2024

Choose a reason for hiding this comment

heinezen commented Apr 29, 2024 • edited Loading

heinezen Apr 29, 2024

Choose a reason for hiding this comment

TheJJ left a comment

Choose a reason for hiding this comment

heinezen commented May 2, 2024

heinezen commented Jul 10, 2024

TheJJ commented Jul 11, 2024 • edited Loading

heinezen commented Jul 12, 2024

heinezen commented Jul 15, 2024

heinezen commented Jul 21, 2024 • edited Loading

heinezen commented Jul 21, 2024

heinezen commented Apr 29, 2024 •

edited

Loading

TheJJ commented Jul 11, 2024 •

edited

Loading

heinezen commented Jul 21, 2024 •

edited

Loading