Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delta graphics offset fixed #228

Merged
merged 2 commits into from
Feb 12, 2015
Merged

delta graphics offset fixed #228

merged 2 commits into from
Feb 12, 2015

Conversation

TheJJ
Copy link
Member

@TheJJ TheJJ commented Feb 11, 2015

fixes wrong start offset for delta graphic definitions.

new variable was inserted at the wrong point.
@TheJJ TheJJ added bug Behaving differently as it should behave area: assets Involved with assets (images, sounds, ...) lang: python Done in Python code labels Feb 11, 2015
@franciscod
Copy link
Contributor

I didn't notice the moved line. Nice job, how did you spot it? 👍

@TheJJ
Copy link
Member Author

TheJJ commented Feb 12, 2015

@Jon0 uses the deltas in his code and noticed the regression

@inakoll
Copy link

inakoll commented Feb 12, 2015

I'm sorry to ask this question here but what is a "delta"? I understand that the games assets are packed in a proprietary binary file format. I just never heard the word "delta" in this context. I've first seen this word in the nyan doc ("runtime delta") so my next questions are :

  • What is a "runtime delta" ?
  • Does Nyan would be used in this particular case
    here?
  • What are the contexts and use cases of Nyan?

Thanks

@TheJJ
Copy link
Member Author

TheJJ commented Feb 12, 2015

@inakoll Unfortunately, this has nothing to do with nyan. These are linked graphics for some other graphic, e.g. shadows for some building are stored as a delta for the normal graphic.

The nyan runtime delta are small "mods", which are applied at runtime.

This means you can imagine having some files describing some unit costs etc, and as nyan supports modding, some files will have updates for the stock files (i.e. villager hp += 10).
As these changes can be accumulated at load-time, this will just create the villager with += 10 hp in the first place, the engine will never know the villager ever had less.

Runtime deltas are actually stored and applied after the initialization, they are needed for tech upgrades that modify values after the unit has had some other values.

And for the usage of nyan: it is a storage format aimed for human readability and moddabilty. You can simply define new units or make changes to existing ones in the form of patches.
This allows everybody having the converted original game files and metadata, but the changes can be shared as simple patches for introducing a tentacle monster or changing unit properties.

andrekupka pushed a commit that referenced this pull request Feb 12, 2015
delta graphics offset fixed
@andrekupka andrekupka merged commit 8567570 into SFTtech:master Feb 12, 2015
@TheJJ TheJJ deleted the convert branch February 12, 2015 15:50
@inakoll inakoll mentioned this pull request Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: assets Involved with assets (images, sounds, ...) bug Behaving differently as it should behave lang: python Done in Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants