Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling overhaul and rev-eng rates for some stuff #693

Closed
wants to merge 8 commits into from
Closed

Spelling overhaul and rev-eng rates for some stuff #693

wants to merge 8 commits into from

Conversation

teaalltr
Copy link
Contributor

Fixed a bunch of typos

@zuntrax zuntrax added the documentation Involves the project documentation label Jan 11, 2017
@zuntrax
Copy link
Contributor

zuntrax commented Jan 11, 2017

Nice. You can add yourself to the authors list in copying.md if you want to (it's mandatory for source code, but since you only changed documentation, it's your choice).

@teaalltr teaalltr changed the title Spelling overhaul Spelling overhaul and rev-eng rates for some stuff Jan 11, 2017
@teaalltr
Copy link
Contributor Author

I mistakenly set my master as the one to pull-request to, so I merged the two in this pull. Sorry for the mess 😄

@zuntrax
Copy link
Contributor

zuntrax commented Jan 11, 2017

Not much of a problem, but you might save yourself some headaches by pushing your changes to a feature branch like Piruzzolo:spelling-fix. Otherwise it easily gets chaotic when opening multiple PRs... 😄

@TheJJ
Copy link
Member

TheJJ commented Jan 11, 2017

I'll take your changes to our upcoming documentation overhaul, then I'll also get rid of your funny merge mess 😛

@@ -15,7 +15,7 @@ There is no wrongdoing, just wrong restraint.
You're in luck. There's various sources for tasks:

- have a look at the [issue tracker](https://github.com/sfttech/openage/issues), especially at the issues labeled [easy](https://github.com/SFTtech/openage/labels/easy) or [just do it](https://github.com/SFTtech/openage/labels/just%20do%20it)
- use [your favourite code searching tool](https://github.com/ggreer/the_silver_searcher) to find `TODO` messages (there's quite a bunch of them)
- use [your favorite code searching tool](https://github.com/ggreer/the_silver_searcher) to find `TODO` messages (there's quite a bunch of them)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nasty nasty US English ;)

Is there actually any decision between one or the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope AFAIK. I'm not a native speaker, so feel free to fix weird corrections 👍

@TheJJ TheJJ mentioned this pull request Jan 21, 2017
@zuntrax zuntrax closed this in #713 Jan 22, 2017
@TheJJ
Copy link
Member

TheJJ commented Jan 22, 2017

I integrated your corrections and additions in #713, thanks for the patches :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Involves the project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants