Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix message for options in CMakeLists #110

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

fmessmer
Copy link
Contributor

I guess the messages have been copy-pasted and not adjusted according to the respective cases

@fmessmer
Copy link
Contributor Author

on a side note:
we are using catkin-tools to build our workspaces, i.e. catkin build
I can set my desired cmake-args with

catkin config -DLDMRS=1 -DSCANSEGMENT_XD=0 -DBUILD_WITH_LDMRS_SUPPORT=True -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON

but that still fails because the dependency declaration in the package.xml is hidden behind an environment variable condition and thus sick_scan_xd does not wait for libsick_ldmrs to be finished - despite the cmake-args
the only ways to enforce the proper build order are:

  • removing the condition in package.xml
  • or run BUILD_WITH_LDMRS_SUPPORT=True catkin build instead of just catkin build

maybe catkin_make_isolated handles this differently and its just a catkin-tools thing
I just wanted to mention it here as it makes integrating sick_scan_xd into our source workspace quite tricky

the best solution of course would be #105
😉

@rostest
Copy link
Collaborator

rostest commented Sep 23, 2022

Thanks for your pull request! The cmake options and help texts are currently shown by cmake-gui, e.g.:
cmake-gui-1
To describe the optional cmake settings as clear as possible, we will add some further explanation in the help text. E.g.:
cmake-gui-2

@rostest rostest merged commit a04c88a into SICKAG:master Sep 23, 2022
@fmessmer fmessmer deleted the fix/cmake_messages branch September 23, 2022 15:19
@fmessmer fmessmer mentioned this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants