Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.4 support #6

Merged
merged 2 commits into from
Feb 15, 2024
Merged

1.20.4 support #6

merged 2 commits into from
Feb 15, 2024

Conversation

Error11O
Copy link
Contributor

adds 1.20.4 support for anyone on the newest version of minecraft and meteor if this doesnt get added just build it from my fork i like this addon so if it stops working ill fix it again.

@SIMULATAN
Copy link
Owner

Hi there!

Thank you so much for your contribution. I attempted to run Minecraft with this patch, however, it crashed upon startup with some ResourcePackManagerMixin failure. Therefore, I bumped the fabric-loom version (and some other dependencies).
Additionally, I changed the version to 3.0.0 as this change isn't backwards-compatible.

If you're fine with it, I'd go ahead and squash merge this PR.

For people coming across this: a dev build is available here

@Error11O
Copy link
Contributor Author

All good with me thanks

@SIMULATAN SIMULATAN merged commit 12b3412 into SIMULATAN:main Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants