Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go through another env var to set --since-tag #233

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Jan 12, 2024

Add a space in GitHub actions variables where there was none to make them look more proper.

Fixes #232

The relevant changes can be found here.

Add a space in GitHub actions variables where there was none to make
them look more proper.
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (892a23b) 81.29% compared to head (c09b13f) 81.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files          12       12           
  Lines         909      909           
=======================================
  Hits          739      739           
  Misses        170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA requested review from ajeklund and daniel-sintef and removed request for ajeklund January 12, 2024 12:15
Copy link

@DanielMarchand DanielMarchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my one suggestion

This is implemented as part of the code review by @DanielMarchand
@CasperWA CasperWA merged commit 862c085 into main Jan 13, 2024
24 checks passed
@CasperWA CasperWA deleted the cwa/fix-232-properly-handle-options branch January 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support first release
2 participants