Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More intricate dependency control #99

Closed
wants to merge 12 commits into from

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Jan 9, 2023

Closes #95

Implement single dependency control based on the ignore config option from Dependabot.

This furthermore updates the Python API (and subsequently the folder structure under the tests/ folder.
Splitting up the individual tasks into individual files under a tasks directory.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #99 (c37eefb) into main (5ba72a6) will increase coverage by 11.98%.
The diff coverage is 65.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main      #99       +/-   ##
===========================================
+ Coverage   53.69%   65.67%   +11.98%     
===========================================
  Files           3        9        +6     
  Lines         311      472      +161     
===========================================
+ Hits          167      310      +143     
- Misses        144      162       +18     
Impacted Files Coverage Δ
ci_cd/tasks/docs_index.py 23.33% <23.33%> (ø)
ci_cd/tasks/setver.py 23.52% <23.52%> (ø)
ci_cd/tasks/api_reference_docs.py 65.41% <65.41%> (ø)
ci_cd/utils.py 69.76% <69.76%> (ø)
ci_cd/tasks/update_deps.py 81.09% <81.09%> (ø)
ci_cd/exceptions.py 100.00% <100.00%> (ø)
ci_cd/tasks/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CasperWA CasperWA marked this pull request as ready for review February 8, 2023 08:59
@CasperWA CasperWA requested a review from francescalb February 8, 2023 08:59
@francescalb
Copy link
Contributor

With the renaming here, I find it hard to see what are the real changes from before and what are the tests for those. It would be useful to go through it together.

@CasperWA
Copy link
Collaborator Author

CasperWA commented Mar 6, 2023

With the renaming here, I find it hard to see what are the real changes from before and what are the tests for those. It would be useful to go through it together.

To make this more parseable and reviewable, I have split this up into 3 PRs.
This PR will be closed in favor of implementing those PRs.

@CasperWA CasperWA closed this Mar 6, 2023
@CasperWA CasperWA deleted the cwa/close-95-dependency-control branch March 10, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to skip or keep dependency at certain level
3 participants