Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile for building with Ubuntu and minimal requirements #729

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Dec 2, 2023

Description

This PR adds a dockerfile for building with minimal requirements on Ubuntu. All non-skipped tests passes.

The issues in #711 with the tests failing instead of being skipped is not reproduced. This could be due to fixes in DLite applied after the issue was created.

The intention with this PR is simply add the Ubuntu dockerfile such that we have it for testing similar issues in the future.

Closes #711

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis removed the request for review from francescalb December 11, 2023 20:25
@jesper-friis jesper-friis merged commit d4c176c into master Dec 12, 2023
11 checks passed
@jesper-friis jesper-friis deleted the 711-building-with-minimal-requirements branch December 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are not skipped when building with minimal requirements
2 participants