Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dims to shape throughout dlite #774

Merged
merged 72 commits into from
Feb 14, 2024

Conversation

alfredoisg
Copy link
Collaborator

@alfredoisg alfredoisg commented Jan 22, 2024

Description

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@alfredoisg alfredoisg linked an issue Jan 22, 2024 that may be closed by this pull request
@jesper-friis jesper-friis changed the title 192 rename dims to shape throughout dlite Rename dims to shape throughout dlite Jan 22, 2024
.dockerignore Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all the following files...

alfredoisg and others added 26 commits February 2, 2024 14:22
…nergies because I donot have atomscaledata.json
* Update sphinx-book-theme requirement from ~=0.3.3 to ~=1.0.1 (#722)

Updates the requirements on [sphinx-book-theme](https://github.com/executablebooks/sphinx-book-theme) to permit the latest version.
- [Release notes](https://github.com/executablebooks/sphinx-book-theme/releases)
- [Changelog](https://github.com/executablebooks/sphinx-book-theme/blob/master/CHANGELOG.md)
- [Commits](executablebooks/sphinx-book-theme@v0.3.3...v1.0.1)

---
updated-dependencies:
- dependency-name: sphinx-book-theme
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update sphinxcontrib-plantuml requirement from ~=0.24 to ~=0.27 (#723)

Updates the requirements on [sphinxcontrib-plantuml](https://github.com/sphinx-contrib/plantuml) to permit the latest version.
- [Commits](sphinx-contrib/plantuml@0.24...0.27)

---
updated-dependencies:
- dependency-name: sphinxcontrib-plantuml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update sphinx requirement from <5,>=4.5.0 to >=4.5.0,<8 (#721)

Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES.rst)
- [Commits](sphinx-doc/sphinx@v4.5.0...v7.2.6)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update sphinx-design requirement from ~=0.3.0 to ~=0.5.0 (#724)

Updates the requirements on [sphinx-design](https://github.com/executablebooks/sphinx-design) to permit the latest version.
- [Release notes](https://github.com/executablebooks/sphinx-design/releases)
- [Changelog](https://github.com/executablebooks/sphinx-design/blob/main/CHANGELOG.md)
- [Commits](executablebooks/sphinx-design@v0.3.0...v0.5.0)

---
updated-dependencies:
- dependency-name: sphinx-design
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Removed some errors in html generation using doxygen

* Moved entities, input and output files to respectively sub-directories.

* Improved naming of files written to output/ directory.

Fixed possible segfault in rdf plugin.

* Added test for writing rdf to non-existing directory

* Made rdf test in test_storage.py robust against dlite being compiled without
rdf support.

* Added driver to url argument of Instance.save()

* Bump actions/configure-pages from 3 to 4 (#734)

Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 3 to 4.
- [Release notes](https://github.com/actions/configure-pages/releases)
- [Commits](actions/configure-pages@v3...v4)

---
updated-dependencies:
- dependency-name: actions/configure-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/deploy-pages from 2 to 3 (#735)

Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 2 to 3.
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](actions/deploy-pages@v2...v3)

---
updated-dependencies:
- dependency-name: actions/deploy-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/setup-python from 4 to 5 (#737)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump SINTEF/ci-cd from 2.6.0 to 2.7.1 (#740)

Bumps [SINTEF/ci-cd](https://github.com/sintef/ci-cd) from 2.6.0 to 2.7.1.
- [Release notes](https://github.com/sintef/ci-cd/releases)
- [Changelog](https://github.com/SINTEF/ci-cd/blob/main/CHANGELOG.md)
- [Commits](SINTEF/ci-cd@v2.6.0...v2.7.1)

---
updated-dependencies:
- dependency-name: SINTEF/ci-cd
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added support for specifying when accessing and assigning properties.

* Added small section to readme file.

* Improved some errors

* Bump actions/download-artifact from 3 to 4 (#746)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-artifact from 3 to 4 (#747)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixing memory bug when printing error message.

* Bump actions/deploy-pages from 3 to 4 (#752)

Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 3 to 4.
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](actions/deploy-pages@v3...v4)

---
updated-dependencies:
- dependency-name: actions/deploy-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/upload-pages-artifact from 2 to 3 (#751)

Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@v2...v3)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixed loading collection with instance_from_dict()

* Added tests for convert_instance()

* Updated tests

* Reverted back to check for _headersize since it is always be larger than zero.

* Added test_collection_load.py to tests and reverted back to check for
_headersize in dlite-schemas.c

* Improved documentation. Changed convert_instance() to raise DLiteTypeError
if we cannot downcast to the expected type.

* Renamed convert_instance() to instance_cast().

* Added missing test file.

* Commented out a tricky test that needs more attention

* Added datatype to relations

* Fixing error return codes

* Corrected initialisation of relation from dict

* Added datatype to triplestore_add()

* Initialised datatype

* Correctly assign triple from rdflib

* Added datatype to triplestore and collection methods

* Do not install rdflib in ci-tests workflow

* Added smart redland triple filter function to allow searching for both
objects and datatypes as expected.

* Cleaned up debugging statements and comments

* Updated triplestore-builtin

* Correctly print/scan relations with datatype

* Updated collection, added tests and fixed bugs

* Removed access to set_default_namespace() from Python.
This method makes little sense and is just confusing.

* Added convenient Collection.value() method

* Corrected rdf plugin and avoid double-free when running test_rdf with DLITE_ATEXIT_FREE

* Update bindings/python/dlite-collection-python.i

Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>

* Changes suggested by reviewer

* Updated dlite as suggested by Francesca.

* Update sphinx-toggleprompt requirement from ~=0.4.0 to ~=0.5.2 (#763)

* Update sphinx-toggleprompt requirement from ~=0.4.0 to ~=0.5.2

Updates the requirements on [sphinx-toggleprompt](https://github.com/jurasofish/sphinx-toggleprompt) to permit the latest version.
- [Release notes](https://github.com/jurasofish/sphinx-toggleprompt/releases)
- [Commits](jurasofish/sphinx-toggleprompt@V0.4.0...V0.5.2)

---
updated-dependencies:
- dependency-name: sphinx-toggleprompt
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updated requirements for consistency

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper.friis@sintef.no>

* Bump SINTEF/ci-cd from 2.7.1 to 2.7.2 (#764)

Bumps [SINTEF/ci-cd](https://github.com/sintef/ci-cd) from 2.7.1 to 2.7.2.
- [Release notes](https://github.com/sintef/ci-cd/releases)
- [Changelog](https://github.com/SINTEF/ci-cd/blob/main/CHANGELOG.md)
- [Commits](SINTEF/ci-cd@v2.7.1...v2.7.2)

---
updated-dependencies:
- dependency-name: SINTEF/ci-cd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update sphinx-copybutton requirement from ~=0.5.1 to ~=0.5.2 (#766)

Updates the requirements on [sphinx-copybutton](https://github.com/executablebooks/sphinx-copybutton) to permit the latest version.
- [Release notes](https://github.com/executablebooks/sphinx-copybutton/releases)
- [Changelog](https://github.com/executablebooks/sphinx-copybutton/blob/master/CHANGELOG.md)
- [Commits](executablebooks/sphinx-copybutton@v0.5.1...v0.5.2)

---
updated-dependencies:
- dependency-name: sphinx-copybutton
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Removed commented out code

* Bump actions/cache from 3 to 4 (#771)

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Implement the class QuanityHelper and use it from an Instance object.

* Fix the import of quantity module (get_quantity_helper)

* Add quantity.py in the CMakeLists

* Modify unit tests on quantity module

* Modify the mongodb storage

* Add a section in the tutorial on how to work with physical quantities.

* Update README.md

* Moved test for pint to top of test_quantity.py

* Updated testing expected exceptions

* Release v0.5.0

* Modify the documentation on mongodb storage.

* Modify user_guide index

* Minor changes in the QuantityHelper

* Release v0.5.1

* Revert version of github upload-artefact action from v4 back to v3, which used to work (#776)

* Updating file permissions

* Updated file permissions

* Fixing permissions of .github/docker/run_cibuildwheel.sh

* Changed shape to dims in dlite-rdf.c

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DLite Developers <Team4.0@SINTEF.no>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Terence Coudert <terence.coudert@sintef.no>
Co-authored-by: Terence Coudert <49948490+terence-coudert@users.noreply.github.com>
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work. Very good

@jesper-friis jesper-friis merged commit 70c22b4 into master Feb 14, 2024
13 checks passed
@jesper-friis jesper-friis deleted the 192-rename-dims-to-shape-throughout-dlite branch February 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename dims to shape throughout dlite
2 participants