Removed use of distutils and drop support for Python 3.7 #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2024
francescalb
approved these changes
Jun 24, 2024
francescalb
added a commit
that referenced
this pull request
Jun 24, 2024
# Description Add support for building wheels for musllinux_1_2. Note that wheelse for python3.12 cannot be built on musllinux. Builds on top of PR #860. ## Type of change - [ ] Bug fix & code cleanup - [x] New feature - [ ] Documentation update - [ ] Test update ## Checklist for the reviewer This checklist should be used as a help for the reviewer. - [ ] Is the change limited to one issue? - [ ] Does this PR close the issue? - [ ] Is the code easy to read and understand? - [ ] Do all new feature have an accompanying new test? - [ ] Has the documentation been updated as necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
distutilspackage is deprecates since Python 3.12 and has to be removed. The only function we used fromdistutilswasdistutils.dir_util.copy_tree(). This function can be replaced withshutil.copytree().However,
shutil.copytree()got the neededdirs_exist_okargument in Python 3.8, which means that we have to drop support for Python 3.7. This is acceptable, since Python 3.7 reached end-of-life in June 2023.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.