-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed memory leaks #895
Fixed memory leaks #895
Conversation
- Fixed leak in json_memload() - Fixed leak in global session when running with DLITE_ATEXIT_FREE set - Added a FIXME for a leak in mapping_create_rec() in src/dlite-mappings.c - Set DLITE_ATEXIT_FREE when running `make memcheck` - Ignore external leaks in pydantic and numpy random_bit_generator
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
cmake/valgrind-dlite.supp
Outdated
# For Pydantic | ||
|
||
{ | ||
<insert_a_suppression_name_here> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please insert a suppression name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment and moved suppression to valgrind-python.supp.
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved when comments have been adressed
Description
Fixed memory leaks. The following was done:
make memcheck
.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.