Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved and simplified building docker images #910

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Aug 10, 2024

Description

Improved and simplified building docker images.

  • fixed and updated the scripts for testing docker images locally
  • factored out the generation of dockerfiles into a separate script that is reused both by the CI/CD and the testing script

Motivation for this PR: Simplify debugging failures when docker images are built, specifically the segfault problem for manylinux2014_i686 on Python 3.12. Improved maintainability.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not using the templates anymore? The, why are the files kept?

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@jesper-friis
Copy link
Collaborator Author

Are we not using the templates anymore? The, why are the files kept?

The templates are still used via the new gen_dockerfile.sh script. This script is in turn used by the CI/CD and the run_cibuildwheel.sh script.

@jesper-friis jesper-friis merged commit 61268cd into master Aug 12, 2024
14 checks passed
@jesper-friis jesper-friis deleted the docker-build branch August 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants