Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cppcheck and corrected some errors that it found #911

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Aug 11, 2024

Description

Updated cppcheck and corrected some errors that it found.

Background for this PR: After updating cppcheck to 2.13.0, it pointed out a few memory leaks. To make it easier to utilise cppcheck, this PR runs it with cache enabled. After the initial run, this makes cppcheck very fast, making it convenient to use during development.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@@ -1,6 +1,6 @@
Transactions
============
Transactions is a concept that comes from SOFT, which allows to easy manage arbitrary long series of immutable (frozen) instances, while ensuring provenance.
Transaction is a concept that comes from SOFT, which allows to easy manage arbitrary long series of immutable (frozen) instances, while ensuring provenance.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird grammar

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

jesper-friis and others added 2 commits August 12, 2024 12:49
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
@jesper-friis jesper-friis merged commit 2d06751 into master Aug 12, 2024
14 checks passed
@jesper-friis jesper-friis deleted the static-analysis branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants