Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation of Python packages #939

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Sep 3, 2024

Description

Improve installation of Python packages and include the following in the distribution:

  • utility programs like dlite-getuuid, dlite-codegen, patch-activate.sh
  • storages, like blob.json
  • README.md and LICENSE files

In addition it fixed a bug in the setup.py script that in addition to dlite-python also installs a pip package called dlite. If you remove that you will remove pip, hense messing with your entire environment.


The changes can be tested locally with

cd python
python setup.py bdist_wheel

and then install the wheel with pip in a newly created environment

pip install dist/DLite_Python-0.5.22-cp310-cp310-linux_x86_64.whl

After that, you should be able to import dlite in the standard manner

python
>>> import dlite

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

- include utility programs like dlite-getuuid
- include storages
- include README.md and LICENSE
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo to correct

Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
@jesper-friis jesper-friis merged commit e85185b into master Oct 7, 2024
14 checks passed
@jesper-friis jesper-friis deleted the python-package branch October 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants