WIP: Added protocol plugins #958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jesper-friis
added
Keep for reference
|
No more need to keep this PR open... |
jesper-friis
added a commit
that referenced
this pull request
Oct 15, 2024
Added protocol plugins to separate protocol from storage driver. The protocol plugins are currently only implemented in Python. Currently 3 protocols plugins has been added: file, http and sftp. Other improvements: * Updated installation of Python packages * Generalised cmake statements by using generator expression * Made urlencode accessible from Python * Improve testing of uriencode()/uridecode() * Fixed some issues the Options class * Updated C implementation of protocol paths * Added to tips and tricks * Ensure that location always is a string, since urlparse on Windows does not support Path objects. * Added documentation * Fixed segfault in Python interface to urlencode() and added parse_query() and make_query() functions. * Updated dlite.options module * Added test_options.py * Added more tests and included protocols to Instance.from_url(url) and save(url) * Cleaning up and simplifying CMakeLists.txt * Reduce MSVS warnings * Added test_plugin.py --------- Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added protocol plugins to separate protocol from storage driver. The protocol plugins are currently only implemented in Python.
Currently 3 protocols plugins has been added:
file,httpandsftp.Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.